Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with moduleForComponent and testing div ID #40

Closed
zigomir opened this issue Apr 17, 2014 · 0 comments
Closed

Problems with moduleForComponent and testing div ID #40

zigomir opened this issue Apr 17, 2014 · 0 comments

Comments

@zigomir
Copy link
Contributor

zigomir commented Apr 17, 2014

I was having problems with testing ember components until I didn't renamed the testing ember app div element's id to ember-testing and set App.rootElement = '#ember-testing' as well.

I looked through the source code and found that moduleForComponent have hardcoded #ember-testing` in it's setup and the container view. I wouldn't change the way it's done right now, but I would at least add some info about it into the readme, so that next me, won't having issues with that.

I know same setup is also used in new ember testing guides and this setup info isn't provided as well. Would it be all right if I just add one step into examples section and describe that you need those two things to be set up as such?

@zigomir zigomir changed the title Problems if you don't have <div id="ember-testing"></div> Problems if you don't have <div id="ember-testing"></div> Apr 17, 2014
@zigomir zigomir changed the title Problems if you don't have <div id="ember-testing"></div> Problems with moduleForComponent and testing div ID Apr 20, 2014
@zigomir zigomir closed this as completed Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant