devmode is a bad name?

[amk221]

The devmode option allows the tests container to run full screen.

This is useful for testing (for example) scrolling a certain size element to a certain location.

Because the dimensions used in the test are related to the actual window size. Not the scaled test container. For which half-size values must be used.

Tests in the browser with devmode will pass, but will fail when run on the command line.

Unless that is, if devmode is added to the testem config.

But, calling it devmode, doesn't make sense if it's being used in what is essentially a test-mode.

Wouldn't it be better to call it what is actually does, which is:

if (params.devmode) {
   testContainer.className = ' full-screen';
}

I'm suggesting it be renamed to fullscreen

[rwjblue]

No objection, mind working up a PR? I think we would have to support both query params (and probably print a warning/deprecation when we see devmode)...

[amk221]

Ok 🙂

I don't want to over-think it, but the current options are:

nocontainer
dockcontainer
devmode

So, on second thoughts, fullscreencontainer would make more sense.

Because fullscreen could be confused with requestFullScreen

[amk221]

After further searching of the code base I see that devmode also influences the test time out. So perhaps I'll just leave it........ 😂

[rohitpaulk]

Not against devmode, but it'd be nice to have fullscreencontainer as a separate option to use in CI. Happy to contribute a PR here - want to confirm if this functionality is acceptable before proceeding:

Add fullscreencontainer as an option, which'll only toggle the container positioning/width but not the timeout (like devmode does).

[rwjblue]

Seems fine to have, but I don't think we should add a checkbox for it.