Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type errors after upgrading to v4.0.3 #1502

Closed
simonihmig opened this issue Sep 4, 2024 · 1 comment · Fixed by #1503
Closed

Type errors after upgrading to v4.0.3 #1502

simonihmig opened this issue Sep 4, 2024 · 1 comment · Fixed by #1503

Comments

@simonihmig
Copy link
Contributor

The latest version, more specifically this PR, seems to cause type errors when upgrading, at least when using a not so recent Ember version and non-native types.

The published declarations/settled.d.ts file has this as its first line:

export declare const checkWaiters: typeof import("ember-testing/lib/test/waiters").checkWaiters;

This probably works if you have latest native types (idk, I assume), but it fails for us with:

      [types] ../../../../node_modules/@ember/test-helpers/declarations/settled.d.ts:1:50 - error TS2307: Cannot find module 'ember-testing/lib/test/waiters' or its corresponding type declarations.
      [types] 
      [types] 1 export declare const checkWaiters: typeof import("ember-testing/lib/test/waiters").checkWaiters;

I don't think there is a need to expose that checkWaiters type to the outside, it is only used internally, isn't it?

cc @NullVoxPopuli

@NullVoxPopuli
Copy link
Collaborator

You make a good point -- here is a PR that removes the export: #1503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants