-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non ember-data models #29
Comments
I would use We can provide a nice helpful assertion though, when you call |
|
👍 for implementing something that is agnostic. I'm using ember-orbit with ember-mocha and was surprised by describeModel (which wraps moduleForModel) breaking on the ED dependency. |
We'd happily review a pull request with a proposed solution. |
Thx @rwjblue, I appreciate your and the rest of contributors' work on this. I realize I'm not contributing much by simply adding my voice in support of the issue, but the intention is to show that there people who would like this, too. If I had the means to add a PR for this right now, I would. I'm a long time open source maintainer myself and I realize how much more valuable contributed code is. Having said that, I do believe it is perfectly valid to add to a project by voicing your needs. You, of course, have no obligation to implement what I ask for. I do not feel entitled to anything in regards to the project. Hey, at least I didn't create a NEW issue without searching existing issues that address my concerns first! |
I am very sorry if that last comment came off as snarky or negative. I was basically saying that I would definitely be open to a fix, just haven't had time (or a personal need) to dig into it myself yet. |
All cool. No worries. I was just leaving a little something behind to show that I appreciate the work on this instead of just being a help vampire (can't think of what the OSS equivalent is at the moment). |
This should be addressed when using the new testing APIs provided by ember-qunit (e.g. moduleForModel is no longer "a thing"). Closing.... |
Files in the
models
folder currently get nerfed due to: https://github.com/switchfly/ember-test-helpers/blob/master/lib/ember-test-helpers/test-module-for-model.js#L41Error:
The text was updated successfully, but these errors were encountered: