-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.subject() throws error in moduleForModel if { integration: true } #46
Comments
This is because I think we should be adding all of these registrations from [inside the |
We should extract those registrations into a stand alone function, then call it from both |
Thanks for the quick reply! For now I've got a workaround using |
@rwjblue you also said this was the same as the "missing component:-text-area" stuff, right? |
Yes |
Added a failing test for this in #51 |
Does it seem reasonable that Ember and Ember Data could maintain this list of registrations? For instance, in Ember, this minimal set of container items could be extracted from the application I know that is beyond the scope of this bug, but I just wanted to see if this was a decent idea. |
@mitchlloyd - Both Ember Data (in the last couple versions) and Ember (since 1.0.0!) have a mechanism for populating a container with what is needed for a default setup. Unfortunately, we haven't been using them here. I submitted #49 to resolve that, and remove this super annoying hard-coding of registrations/options/etc. |
Resolved and released in ember-test-helpers@0.5.0 and ember-qunit@0.4.0. |
I have a test where I was passing
{ integration: true }
in order to use a model with a hasMany relationship. After upgrading from 0.3.1 to 0.3.2, runningthis.subject()
throws an error:I've found that when setting the integration flag,
this.container.lookup('store:main')
returnsundefined
. Without the flag,this.container.lookup('store:main')
returns a store object.The text was updated successfully, but these errors were encountered: