Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "integration: true" and "needs" #55

Closed
johnnyshields opened this issue Jun 2, 2015 · 2 comments
Closed

Document "integration: true" and "needs" #55

johnnyshields opened this issue Jun 2, 2015 · 2 comments

Comments

@johnnyshields
Copy link

I don't see any mention of integration: true or needs in the README for this lib. As I understand it those are the args for the methods in this lib.

Secondly, as an aside related to Ember itself, it would be better if we leveraged ES6's brilliant module functionality and import the modules which each model class needs in model class itself (like every other JS framework) rather than trying to be Ruby-esque and autoload the classes via a "Resolver". This would avoid the whole integration / needs stuff in the tests entirely.

@Turbo87
Copy link
Member

Turbo87 commented Feb 6, 2017

@johnnyshields that would also make stubbing/mocking impossible or at least much harder compared to using dependency injection.

@rwjblue
Copy link
Member

rwjblue commented Oct 14, 2017

FWIW, emberjs/rfcs#229 makes integration: true the only non-deprecated path forward.

ember-test-helpers is a lower level library that is leveraged by ember-qunit and ember-mocha. The README for ember-qunit includes documentation around integration: true at this point, so I'm going to go ahead and close this issue...

@rwjblue rwjblue closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants