[FEATURE ember-glimmer-angle-bracket-built-ins]

Remove `{{dash-rule}}` for curly invocations.

Author: chancancode

packages/@ember/-internals/glimmer/lib/syntax.ts

@@ -1,4 +1,5 @@
 import { OwnedTemplateMeta } from '@ember/-internals/views';
+import { EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS } from '@ember/canary-features';
 import { assert } from '@ember/debug';
 import { CompilableBlock } from '@glimmer/interfaces';
 import { Macros, OpcodeBuilder } from '@glimmer/opcode-compiler';
@@ -26,7 +27,8 @@ function refineInlineSyntax(
       builder.referrer.owner.hasRegistration(`helper:${name}`)
     )
   );
-  if (name.indexOf('-') === -1) {
+
+  if (!EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS && name.indexOf('-') === -1) {
     return false;
   }
 
@@ -48,7 +50,7 @@ function refineBlockSyntax(
   inverse: Option<CompilableBlock>,
   builder: OpcodeBuilder<OwnedTemplateMeta>
 ) {
-  if (name.indexOf('-') === -1) {
+  if (!EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS && name.indexOf('-') === -1) {
     return false;
   }
 
@@ -97,11 +99,14 @@ export function populateMacros(macros: Macros) {
   inlines.add('outlet', outletMacro);
   inlines.add('mount', mountMacro);
   inlines.add('input', inputMacro);
-  inlines.add('textarea', textAreaMacro);
   inlines.addMissing(refineInlineSyntax);
   blocks.add('let', blockLetMacro);
   blocks.addMissing(refineBlockSyntax);
 
+  if (!EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS) {
+    inlines.add('textarea', textAreaMacro);
+  }
+
   for (let i = 0; i < experimentalMacros.length; i++) {
     let macro = experimentalMacros[i];
     macro(blocks, inlines);

packages/@ember/-internals/glimmer/lib/syntax/textarea.ts

@@ -1,22 +1,39 @@
 import { OwnedTemplateMeta } from '@ember/-internals/views';
 import { EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS } from '@ember/canary-features';
+import { DEBUG } from '@glimmer/env';
 import { Option } from '@glimmer/interfaces';
 import { OpcodeBuilder } from '@glimmer/opcode-compiler';
+import { unreachable } from '@glimmer/util';
 import * as WireFormat from '@glimmer/wire-format';
 import { wrapComponentClassAttribute } from '../utils/bindings';
 import { hashToArgs } from './utils';
 
-export function textAreaMacro(
-  _name: string,
+export let textAreaMacro: (
+  name: string,
   params: Option<WireFormat.Core.Params>,
   hash: Option<WireFormat.Core.Hash>,
   builder: OpcodeBuilder<OwnedTemplateMeta>
-) {
-  let definition = builder.compiler['resolver'].lookupComponentDefinition(
-    EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS ? 'textarea' : '-text-area',
-    builder.referrer
-  );
-  wrapComponentClassAttribute(hash);
-  builder.component.static(definition!, [params || [], hashToArgs(hash), null, null]);
-  return true;
+) => boolean;
+
+if (EMBER_GLIMMER_ANGLE_BRACKET_BUILT_INS) {
+  if (DEBUG) {
+    textAreaMacro = () => {
+      throw unreachable();
+    };
+  }
+} else {
+  textAreaMacro = function textAreaMacro(
+    _name: string,
+    params: Option<WireFormat.Core.Params>,
+    hash: Option<WireFormat.Core.Hash>,
+    builder: OpcodeBuilder<OwnedTemplateMeta>
+  ) {
+    let definition = builder.compiler['resolver'].lookupComponentDefinition(
+      '-text-area',
+      builder.referrer
+    );
+    wrapComponentClassAttribute(hash);
+    builder.component.static(definition!, [params || [], hashToArgs(hash), null, null]);
+    return true;
+  };
 }

packages/@ember/-internals/glimmer/tests/integration/components/curly-components-test.js

@@ -1281,7 +1281,29 @@ moduleFor(
       this.assertText('some-prop some-component');
     }
 
-    ['@test component without dash is not looked up']() {
+    ['@feature(ember-glimmer-angle-bracket-built-ins) component without dash is looked up']() {
+      this.registerComponent('somecomponent', {
+        template: 'somecomponent',
+      });
+
+      this.render('{{somecomponent}}', {
+        somecomponent: 'notsomecomponent',
+      });
+
+      this.assertText('somecomponent');
+
+      this.assertStableRerender();
+
+      runTask(() => this.context.set('somecomponent', 'not not notsomecomponent'));
+
+      this.assertText('somecomponent');
+
+      runTask(() => this.context.set('somecomponent', 'notsomecomponent'));
+
+      this.assertText('somecomponent');
+    }
+
+    ['@feature(!ember-glimmer-angle-bracket-built-ins) component without dash is not looked up']() {
       this.registerComponent('somecomponent', {
         template: 'somecomponent',
       });