Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 1.11 when binding to element.id in components #10769

Closed
jnfingerle opened this issue Mar 30, 2015 · 4 comments
Closed

Regression in 1.11 when binding to element.id in components #10769

jnfingerle opened this issue Mar 30, 2015 · 4 comments

Comments

@jnfingerle
Copy link

I'm using

id: Ember.computed('element.id', function(){
    return "foo_" + this.get('element.id');
}),

in components to generate unique ids for my components' markup.

Boiled down into a jsbin, this works in 1.10: http://emberjs.jsbin.com/sunigalodi/1/edit?html,css,js,output

The same doesn't work in 1.11: http://emberjs.jsbin.com/sunigalodi/2/edit?html,css,js,output

(Just follow the Foo links.)

@jnfingerle
Copy link
Author

Just to let you know: I've changed this code to elementId which works and would have been better used in the first place. But I still think, that this regression shouldn't have happened.

@pixelhandler
Copy link
Contributor

@jnfingerle not that you have a work around do you still think this is work fixing and backporting the change to the 1.11.x version of Ember? I'm not sure there are plans for releases to 1.11 other than security releases.

@rwjblue
Copy link
Member

rwjblue commented Jul 25, 2015

👍 - to using elementId. Also, #11889 addresses this slightly (though not this exact use case).

@rwjblue rwjblue closed this as completed Jul 25, 2015
@jnfingerle
Copy link
Author

It breaks semVer. From what I understand, that should not happen. Having said that, I don't have a problem with this any more, so I'm fine with closing it, which @rwjblue already did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants