Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canary - Poor bind-attr deprecation warning messages #11133

Closed
danmcclain opened this issue May 12, 2015 · 2 comments · Fixed by #11138
Closed

Canary - Poor bind-attr deprecation warning messages #11133

danmcclain opened this issue May 12, 2015 · 2 comments · Fixed by #11138

Comments

@danmcclain
Copy link
Contributor

The bind-attr deprecation warning error message does not yield any context where the issue is coming from:

DEPRECATION: The `bind-attr` helper is deprecated in favor of HTMLBars-style bound attributes
        at isBindAttrModifier (/Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-template-compiler.js:9626:24)
        at /Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-template-compiler.js:9521:15
        at Walker.visit (/Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-template-compiler.js:15411:7)
        at visitors.Program (/Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-template-compiler.js:15421:16)
        at Walker.children (/Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-template-compiler.js:15444:7)
        at Walker.visit (/Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-template-compiler.js:15412:12)
        at TransformBindAttrToAttributes_transform [as transform] (/Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-
template-compiler.js:9516:12)
        at Object.preprocess (/Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-template-compiler.js:15011:27)
        at compileSpec (/Users/dan/Projects/dockyard/client_work/web-client/bower_components/ember/ember-template-compiler.js:10535:22)

/cc @rwjblue
@rwjblue
Copy link
Member

rwjblue commented May 12, 2015

👍 - We need to add the filename + line/column info to this deprecation.

@rwjblue
Copy link
Member

rwjblue commented May 12, 2015

I'll tackle shortly....

@rwjblue rwjblue mentioned this issue May 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a better deprecation for {{bind-attr}}. rwjblue/ember.js
2 participants
@rwjblue @danmcclain