Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String.length returns undefined for empty string in 1.12 #11204

Closed
paddyobrien opened this issue May 18, 2015 · 0 comments · Fixed by #11205
Closed

String.length returns undefined for empty string in 1.12 #11204

paddyobrien opened this issue May 18, 2015 · 0 comments · Fixed by #11205

Comments

@paddyobrien
Copy link

JSBin: http://emberjs.jsbin.com/peposiconi/1/edit?html,js,console,output

It seems that in 1.12 accessing the length property of an empty string through a getter returns undefined rather than0.

Previously zero was returned as expected.

It looks like this got broken here: 1a3dde2#diff-1b9682e6b936bfe3101e35ff6e574957R61

Proposed fix: master...paddyobrien:paddy/get-empty-string-length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX release] Fix get with empty string paddyobrien/ember.js
1 participant
@paddyobrien