Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{link-to data-someattr="Some Value"}} no longer works #11391

Closed
mfpiccolo opened this issue Jun 9, 2015 · 3 comments
Closed

{{link-to data-someattr="Some Value"}} no longer works #11391

mfpiccolo opened this issue Jun 9, 2015 · 3 comments

Comments

@mfpiccolo
Copy link

In the guides to allow data attributes to be added to the link-to helper it suggests reopening Ember.View.

This functionality no longer works in v1.13.0-beta.

This is most likely related to #11390

JSBins:
v1.13.0-beta
v1.12.0

PS Thanks you @jmurphyau, I used your jsbins

@amk221
Copy link

amk221 commented Jul 15, 2015

Is this a bigger issue now affecting all components not just link views?
init is called too early for access to attrs
didInitAttrs is called too late to get the attrs and add them to attributeBindings
http://jsbin.com/vidazi/edit?html,js,output

@aortbals
Copy link
Contributor

aortbals commented Aug 2, 2015

This doesn't appear to affect other components, only the LinkView component. See #11763. This seems to affect all bound attributes on link-to.

Issues: class #11390, #11763, tabindex #11763

@rwjblue
Copy link
Member

rwjblue commented Aug 2, 2015

Thanks @aortbals for doing the research here. Closing in favor of #11699 (but will be updating with your summary of issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants