IE8: {{input type=""}} returns an error #11553
Comments
|
Using Edit: second that, value bindings don't work at that point |
|
In the < case, consider using an action to be notified of the DOM change |
|
A temporary solution would be: But @rwjblue said he will look into this for 1.13.3 |
this is actually likely the best solution moving forward, although the original should also continue to work. |
|
Any idea if 1.13.3 would land this week? |
|
@MichaelVdheeren - 1.13.3 should be out this week, but it hasn't fixed this issue yet. |
|
I ran into this also. I looked into it a bit, and the cause seems to be Ember trying to set the type of the input element after it has been inserted into the DOM tree. IE 8 does not allow this. Also, I tried the workaround with |
|
@XrXr have you tried 1.13.3 ? |
|
@stefanpenner yes |
into a fragment, it shouldn't be trying to insert it after its been inserted into the regular tree. |
|
@stefanpenner It turns out I was half correct. :P I did a quick search and found that setting It happens that the same error happens if the element is a part of a document fragment. Below is a small test case <!DOCTYPE html>
<html>
<body>
<script>
var input = document.createElement('input');
var docFragment = document.createDocumentFragment();
docFragment.appendChild(input);
input.setAttribute('type', 'text'); // throws in IE8
alert('not reached');
</script>
</body>
</html>So the type of an input element must be set before it is inserted into any tree. |
This sounds reasonable, thanks for digging into this further. Are there other attributes like this? |
|
I don't know if there are any other attribute that have this behaviour. If there are any, we can be sure that there will be bug reports :) |
|
I have opened another issue on HTMLBars to track this. We will have to fix this for 1.13.x, which is a shame since it wont be needed for 2.x at all. |
|
By the way just, |
|
@XrXr ya, I would imagine. |
|
Is there any update on this bug? |
I plan to look at it soon. Sorry for the delay, my queue has been full. |
|
tracking issue: tildeio/htmlbars#380 |
|
Fixed by #12596. |
Using IE8 and Ember.js 1.13.2
When using
{{input type="checkbox"}}IE8 shows a "this command is not supported" error. I guess this is the result of the type being set after the input element is rendered which is not possible in IE8.http://stackoverflow.com/questions/18240063/ie8-throws-this-command-is-not-supported-error-when-using-knockout-for-data-bi
The text was updated successfully, but these errors were encountered: