[Bug] Additional attributeBindings on LinkView do not work as of 1.13.0

[mike-north]

If developers wish to add attributes to their anchor tags, beyond the standard set supported by ember out of the box,

{{link-to "My link" "index" data-activates="activate-me"}}

the advised approach is something like this

  Ember.LinkView.reopen({
    attributeBindings: ['data-activates']
  });

This approach works in ember 1.12.x but does not in 1.13.x. This is due to the replacement of LinkView with LinkComponent.

My proposed fix is something like

Ember.LinkView.reopenClass({
  reopen: function () {
    Ember.LinkComponent.reopen.apply(Ember.LinkComponent, arguments);
  }
});

which seems to work.

I'm happy to work on a PR once I get the "go ahead" on this approach

[ef4]

This seems like an acceptable way to provide backward compatibility. It looks a little WAT, but since accessing LinkView is already deprecated, I'm ok with it.

👍

[adentranter]

Is there a reason this can't be used for adding the 'onclick'?

Example