Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner component action sent to wormhole component instead of outer component #12317

Closed
mdehoog opened this issue Sep 10, 2015 · 2 comments
Closed

Comments

@mdehoog
Copy link

mdehoog commented Sep 10, 2015

I use ember-wormhole (https://github.com/yapplabs/ember-wormhole) for modal dialogs in my app. When an "outer" component has an "inner" component that's inside a wormhole, and the "inner" component sends an action, the action used to be fired on the "outer" component. Since PR #12289, the action is fired on the wormhole itself, which causes the error:

Uncaught Error: <emberapp@component:ember-wormhole::ember609> had no action handler for: actionName

Note that this is only an error if the "inner" component and wormhole are defined in an "outer" component template; the action works fine if the component/wormhole are in a controller template.

This fiddle reproduces the issue: http://ember-twiddle.com/1c59a1dcdb18eec69a8e. Changing the ember dependency from canary to release in twiddle.json fixes the issue.

@stefanpenner
Copy link
Member

this may be a regression

@rwjblue
Copy link
Member

rwjblue commented Apr 20, 2016

I tested the provided Twiddle against 2.4/2.5 and canary. All seems to be working properly now.

Sorry for the delay here...

@rwjblue rwjblue closed this as completed Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants