Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextual components does not carry information about source for local lookup #13346

Closed
Serabe opened this issue Apr 15, 2016 · 3 comments
Closed
Assignees

Comments

@Serabe
Copy link
Member

Serabe commented Apr 15, 2016

For reference, Contextual Components RFC and local lookup is being discussed as part of emberjs/rfcs#124.

Currently, when creating a contextual component, we only close over the path of the component, either by reading it from the first param or by getting it from the other contextual component (

[COMPONENT_PATH]: componentCell[COMPONENT_PATH],
).

Local Lookup needs to know the source as well. For that reason, a COMPONENT_PATH_SOURCE and treat it exactly like COMPONENT_PATH. Then the component hook needs to be updated to use it as source if it gets a component cell.

@rwjblue
Copy link
Member

rwjblue commented Apr 15, 2016

👍 - Thanks for reporting, do you plan to pick up implementation of this?

@Serabe
Copy link
Member Author

Serabe commented Apr 15, 2016

Yes.

@Serabe
Copy link
Member Author

Serabe commented Oct 28, 2016

Fixed in #14421

@Serabe Serabe closed this as completed Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants