Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why this benchmark make Ember the worst framework? #14151

Closed
ghost opened this issue Aug 29, 2016 · 3 comments
Closed

Why this benchmark make Ember the worst framework? #14151

ghost opened this issue Aug 29, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 29, 2016

Why this benchmark make Ember the worst framework?

They may not know to use it?

http://www.stefankrause.net/wp/?p=301

@ef4
Copy link
Contributor

ef4 commented Aug 29, 2016

I got a 2.6x speedup on their 1000 rows insert benchmark by factoring out the my-row component (which doesn't do anything you can't do directly in the my-table component).

But it's true that component-heavy composition patterns in current stable Ember don't perform as well as we'd want. Which is why we wrote Glimmer2, which is already in alpha testing.

That said, "Ember" encompasses a lot more functionality than the alternatives it's being compared to. A more meaningful comparison would be to benchmark Glimmer directly (because Glimmer is Ember's view layer, comparable in functionality to most of the others).

@ef4 ef4 closed this as completed Aug 29, 2016
@Adriaaaaan
Copy link

Its especially unfair when you consider the react test case doesn't use a component for the row. Regardless it would be interesting to see if glimmer 2 improves the worst case scenario like this

@ghost
Copy link
Author

ghost commented Aug 30, 2016

It will be great to see the Glimmer 2 tests on this.

Any volunteers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants