Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need to warm guidFor? #14152

Closed
chancancode opened this issue Aug 29, 2016 · 3 comments
Closed

Do we need to warm guidFor? #14152

chancancode opened this issue Aug 29, 2016 · 3 comments
Assignees
@chancancode @krisselden
Labels
Performance

Comments

@chancancode
Copy link
Member

chancancode commented Aug 29, 2016 •
edited
Loading

@krisselden mentioned that we might need to warm guidFor after landing #14139

We don't have a lot of details right now, just don't want to lose track of this
@chancancode chancancode added this to the 2.9.0 milestone Aug 30, 2016
@rwjblue
Copy link
Member

rwjblue commented Apr 29, 2017

@krisselden - Do you still think this is something we should do?

@rwjblue rwjblue modified the milestone: 2.10.0 Apr 29, 2017
@stefanpenner
Copy link
Member

Ya

@bekzod
Copy link
Contributor

bekzod commented Mar 23, 2018

since guidFor using WeakMap https://github.com/emberjs/ember.js/blob/master/packages/ember-utils/lib/guid.js#L40 I think this is not valid anymore ?

@rwjblue rwjblue closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chancancode chancancode

@krisselden krisselden

Labels
Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stefanpenner @rwjblue @chancancode @krisselden @bekzod