Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.13 custom elements regression once more #15258

Closed
bjornharrtell opened this issue May 19, 2017 · 5 comments
Closed

2.13 custom elements regression once more #15258

bjornharrtell opened this issue May 19, 2017 · 5 comments

Comments

@bjornharrtell
Copy link

bjornharrtell commented May 19, 2017 •
edited
Loading

Seems glimmerjs/glimmer-vm#453 was only partially fixed.

I get Error: expected an implementation for 6 with:
http://jsbin.com/nesosateji/edit?html,js,output

And I get Error: expected an implementation for 1 with:
http://jsbin.com/batohesuyu/edit?html,css,js,output
@bjornharrtell bjornharrtell mentioned this issue May 19, 2017
Closed
@bjornharrtell
Copy link
Author

Tracking issues for Glimmer:
glimmerjs/glimmer-vm#493
glimmerjs/glimmer-vm#494

@bjornharrtell bjornharrtell mentioned this issue May 19, 2017
Merged
@rwjblue
Copy link
Member

rwjblue commented May 19, 2017

Awesome, thank you!

@bjornharrtell
Copy link
Author

JSBin links was wrong here (was corrected only in the glimmer issues), is now fixed.

@rwjblue
Copy link
Member

rwjblue commented May 28, 2017

Thank you

@bjornharrtell
Copy link
Author

Bumping to 2.13.3 in the bins shows that this issue is no more:

http://jsbin.com/sesukafewa/edit?html,js,output
http://jsbin.com/lokuqacebe/edit?html,css,js,output

@dunnkers dunnkers mentioned this issue Jun 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @bjornharrtell