regression 3.0: ArrayProxy#pushObjects doesn't accept ArrayProxy

[hjdivad]

#16131 cleaned up a lot of Enumerable and Array mixin code.

However it also changed the assertion in pushObjects from checking for Enumerable or Array to only checking Array

This assertion now throws when calling hasMany.pushObjects(otherHasManyOrRecordArray) even though ember-data's ManyArray can accept these objects.

After going over this with @rwjblue I think the path forward is

• Drop the assertion in pushObjects entirely
• docs: Implementations have to assert their arguments in replace (which is the method implementations of MutableArray are expected to implement)

NativeArray already does assert in replace and ArrayProxy doesn't need to as it delegates to content.

[rwjblue]

Thanks for writing this up, @hjdivad! Agreed on the path forward...

@mmun - any objections?

[mmun]

@rwjblue Nope, this seems good.

It would also be useful if we could mark all the methods that are derived from replace as "final" so that people don't override them.

[runspired]

using Ember.isArray instead of Array.isArray is sufficient here.

[rwjblue]

@runspired - Yes, that would work right, but I believe that it muddies the waters a bit more than the proposed fix...

[devdemi]

I have same problem I can't use pushObjects passing RecordArray.

[nlfurniss]

@devdemi you can get around the issue currently by called toArray on the Enumerable you're trying to push in

myCollection.pushObjects(newElements.get('elements').toArray());