Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation missing for Component helper #16638

Closed
GregoryAveryWeir opened this issue May 15, 2018 · 2 comments
Closed

Documentation missing for Component helper #16638

GregoryAveryWeir opened this issue May 15, 2018 · 2 comments

Comments

@GregoryAveryWeir
Copy link

In 3.1, the way the {{component}} helper works changed, resulting in the documentation apparently going away.

https://www.emberjs.com/api/ember/3.0/classes/Ember.Templates.helpers/methods/component?anchor=component does not exist in the 3.1 docs, despite being linked from https://guides.emberjs.com/v3.1.0/components/wrapping-content-in-a-component/#toc_sharing-component-data-with-its-wrapped-content

API docs should exist for contextual components and the guide above should link to them.

@Gaurav0
Copy link
Contributor

Gaurav0 commented Jun 21, 2018

Previously documented in packages/ember-glimmer/lib/helpers/component.ts: https://github.com/emberjs/ember.js/blob/v2.18.2/packages/ember-glimmer/lib/helpers/component.ts

I cannot find this documentation any more anywhere in this repo or the glimmer.js monorepo.

Does anyone know where this might have been moved to or if it was just deleted?

The commit where the documentation was deleted 660198c

This commit was part of the PR #15828

@rwjblue
Copy link
Member

rwjblue commented Jul 27, 2018

Fixed by #16766

@rwjblue rwjblue closed this as completed Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants