-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event.target not set for mouseEnter/Leave w/o jQuery in IE11 #17228
Comments
Yes, exactly. We only run IE11 with jQuery. |
@rwjblue would this be a fair statement, "Ember w/o jQuery is only supported on evergreen browsers, and Safari, so IE11 is must use jQuery" ? |
FWIW, for one of our apps, we dropped jQuery long before we dropped IE11 support. And AFAIK the other tests run fine w/o jQuery (would need to be confirmed), only this rather edge-casey thing makes some problems... |
I believe this is resolved, @simonihmig can you confirm and close if you agree? |
@rwjblue I don't think so, unfortunately! At least if you refer to #17227, which fixes that However this issue refers to the fact that |
Closing due to inactivity. Post-Octane we are also moving towards |
While working on #17227, and having somehow figured out how to run the (ES5-transpiled, jQuery-less) tests in the browser (used
/tests/index.html?ie=true&dist=prod&skipPackage=container%2Cember-testing%2C%40ember%2Fdebug&moduleId=4a92ac35&jquery=none
), I found that a couple of tests are failing in IE11 due toEvent.target
beingnull
when using the special handling of mouseEnter/Leave when jQuery is not used.It's only those assertions for
Event.target
, the actual events get fired correctly. See here:This brings up two questions:
why weren't these failing in CI? I guess the browserstack tests do not run the no-jquery tests, but not sure. @rwjblue can you confirm?
how to fix this? The event target is set here for the fake event used in the special handling of mouseEnter/Leave (introduced in [BUGFIX release] fix mouseEnter/Leave event delegation w/o jQuery #16999): https://github.com/emberjs/ember.js/blob/master/packages/%40ember/-internals/views/lib/system/event_dispatcher.js#L326
It seems for IE11 this is a readonly, non-configurable property, so neither directly setting it nor using
defineProperty()
(as it is now) works for IE. And of course we cannot use a native Proxy. 🤔The text was updated successfully, but these errors were encountered: