Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should @ember/instrumentation be public API? #17703

Closed
xg-wang opened this issue Mar 4, 2019 · 3 comments
Closed

Should @ember/instrumentation be public API? #17703

xg-wang opened this issue Mar 4, 2019 · 3 comments

Comments

@xg-wang
Copy link
Contributor

xg-wang commented Mar 4, 2019

@ember/instrumentation has been marked private since @rwjblue 's PR in 2015, should the module be considered as public API?
@runspired
Copy link
Contributor

I think this is a question for RFC discussion

@xg-wang
Copy link
Contributor Author

xg-wang commented Mar 6, 2019

Would love to write one. Should this issue moved to rfc repo?

@xg-wang xg-wang mentioned this issue Apr 3, 2019
Closed
@xg-wang
Copy link
Contributor Author

xg-wang commented Apr 9, 2019

See comment #17848 (comment)

@xg-wang xg-wang closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@runspired @xg-wang