Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] remove enabled feature flags on release #18060

Closed
chancancode opened this issue May 29, 2019 · 11 comments · Fixed by #19229
Closed

[CLEANUP] remove enabled feature flags on release #18060

chancancode opened this issue May 29, 2019 · 11 comments · Fixed by #19229

Comments

@chancancode
Copy link
Member

chancancode commented May 29, 2019

@mul53
Copy link

mul53 commented Jun 14, 2019

@chancancode can i have a crack at this?

@rajankumar549
Copy link

Hey, can i help to fix this issue. I want to contribute in this project. @chancancode

@chancancode
Copy link
Member Author

@mul53 @rajankumar549 you don't need permission, just go ahead and open PR. Preferably one feature flag at a time and maybe add a note here on what you are working on so others can pick something else.

@neonick
Copy link

neonick commented Sep 26, 2019

@chancancode seems it could be closed?

@kanavpruthi
Copy link

I am a beginner, and id like to work on a new issue here

@chancancode
Copy link
Member Author

@kanavpruthi the specific set of enabled features to remove has changed since this was opened, but there are now new ones that needed to be cleaned up https://github.com/emberjs/ember.js/blob/master/packages/@ember/canary-features/index.ts

@liberalterian
Copy link

Should all of the features in /packages/@ember/canary-features/index.ts have their respective feature flags removed?

@pzuraq
Copy link
Contributor

pzuraq commented Oct 1, 2020

@Alpine-lines any flag that has been set to true, and has been released in a minor version of Ember, should be removed. Currently, these ones: https://github.com/emberjs/ember.js/blob/master/packages/@ember/canary-features/index.ts#L19-L23

@pzuraq
Copy link
Contributor

pzuraq commented Oct 1, 2020

The best way to approach this is with one PR per feature flag, to make it easier to review quickly

@locks
Copy link
Contributor

locks commented Oct 13, 2021

Reopening until the last two PRs are merged.

@SOUMOJIT-CHAKRABORTY
Copy link

@chancancode Sir I have just learnt javascript and made an web calculator.I want to contribute on opensource, so can you tell me where from I should start?

@locks locks closed this as completed Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants