-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] remove enabled feature flags on release #18060
Comments
@chancancode can i have a crack at this? |
Hey, can i help to fix this issue. I want to contribute in this project. @chancancode |
@mul53 @rajankumar549 you don't need permission, just go ahead and open PR. Preferably one feature flag at a time and maybe add a note here on what you are working on so others can pick something else. |
@chancancode seems it could be closed? |
I am a beginner, and id like to work on a new issue here |
@kanavpruthi the specific set of enabled features to remove has changed since this was opened, but there are now new ones that needed to be cleaned up https://github.com/emberjs/ember.js/blob/master/packages/@ember/canary-features/index.ts |
Should all of the features in /packages/@ember/canary-features/index.ts have their respective feature flags removed? |
@Alpine-lines any flag that has been set to |
The best way to approach this is with one PR per feature flag, to make it easier to review quickly |
Reopening until the last two PRs are merged. |
@chancancode Sir I have just learnt javascript and made an web calculator.I want to contribute on opensource, so can you tell me where from I should start? |
PRs
The text was updated successfully, but these errors were encountered: