Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] Regression when using @each on an array with undefined elements #18474

Closed
boris-petrov opened this issue Oct 8, 2019 · 1 comment · Fixed by #18477
Closed

[3.13] Regression when using @each on an array with undefined elements #18474

boris-petrov opened this issue Oct 8, 2019 · 1 comment · Fixed by #18477
Milestone

Comments

@boris-petrov
Copy link
Contributor

boris-petrov commented Oct 8, 2019

Here is a reproduction repo

The last commit downgrades Ember to 3.12 and the example works. The previous is on Ember 3.13 and does not.

Having a computed property that depends on an array with undefined in it by using @each is broken in 3.13.

P.S. The error is something like When using @each to observe the array ``, the items in the array must be objects.

@pzuraq
Copy link
Contributor

pzuraq commented Oct 8, 2019

Can confirm this is a change in behavior, the original assertion this was based on only runs against non-falsy values (terribly inconsistent, but no reason it should have changed). Will try to get a fix in for this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants