Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember is minified even in development #20794

Open
boris-petrov opened this issue Nov 14, 2024 · 6 comments
Open

Ember is minified even in development #20794

boris-petrov opened this issue Nov 14, 2024 · 6 comments

Comments

@boris-petrov
Copy link
Contributor

🐞 Describe the Bug

For a few releases now, running ember serve leads to a minified build even though it's in development. I'm talking about Ember itself.

🔬 Minimal Reproduction

ember new --pnpm ember-development-minified
cd ember-development-minified
pnpm start

Open http://localhost:4200/, open the devtools and check the assets/vendor/ember/ember.js file. It's minified.

😕 Actual Behavior

Minified Ember which is difficult to use and debug.

🤔 Expected Behavior

Not minified Ember.

🌍 Environment

  • Ember: 5.12.0
  • Ember-CLI: 5.12.0
  • Node.js/npm: v23.1.0
  • OS: Linux
  • Browser: N/A

➕ Additional Context

Possibly due to this PR.

@kategengler
Copy link
Member

I checked this with a new app generated with 6.0 and one with 5.12 and assets/vendor/ember/ember.js is not minified but it does have all whitespace removed. Hitting pretty-print in the inspector solves that. Any other clues to reproducing?

@boris-petrov
Copy link
Contributor Author

boris-petrov commented Nov 15, 2024 via email

@kategengler
Copy link
Member

I had to test to be sure, but I have no problem putting breakpoints nor stepping through even with pretty print.

@acorncom
Copy link
Contributor

@boris-petrov which browser are you using in development? Potentially a difference in handling debugging post pretty-printing?

@boris-petrov
Copy link
Contributor Author

I'm not sure how you do it.

chrome-devtools

Here I tried putting a breakpoint on if (obj.isDestroyed) {. Look where it put it. That's in Chrome's devtools. Or is there some other way of pretty-printing which fixes this and the stepping-into experience that I don't know of?

@kategengler
Copy link
Member

I'm not sure -- in my case I can set breakpoints in the - lines and they stay there (on Chrome devtools).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants