Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router error substate promise rejection results in redirect. #4573

Closed
nathanhammond opened this issue Mar 21, 2014 · 2 comments · Fixed by tildeio/router.js#87
Closed

Router error substate promise rejection results in redirect. #4573

nathanhammond opened this issue Mar 21, 2014 · 2 comments · Fixed by tildeio/router.js#87
Assignees
Labels

Comments

@nathanhammond
Copy link
Member

Versions: Occurs in 1.4, 1.5, and 1.6
Reduction: http://emberjs.jsbin.com/qudek/2/edit

Test Procedure:

  1. Click the link to "slow error"
  2. Before the timeout triggers (3 seconds) click "blue"
  3. Note that the error substate replaces the "blue" route.

I feel like we're missing a transition.abort(); somewhere.

@machty

@ef4
Copy link
Contributor

ef4 commented Apr 2, 2014

This has bitten me too now. In my case the only "error" is a redirect that causes TransitionAborted. The redirect happens and even flashes on screen briefly, but then we transition to the error route anyway.

@ef4
Copy link
Contributor

ef4 commented Apr 2, 2014

I bisected the bug, it was introduced in 808419c, @machty's query params rewrite. Which doesn't narrow it down much, because that's a pretty big patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants