You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To append classes to a component's HTML, you can do a few things:
Add classNames: [] property to the JS
Pass in classNames = 'a b' when invoking the component
Pass in class = 'a b' when invoking the component
Considering that setting class: [] in JS is not valid, I think 2 and 3 should be consolidated. My personal preference would be to deprecate/remove the third option.
The text was updated successfully, but these errors were encountered:
I agree with you in general, but it is very unlikely that we would make changes here. Instead we would prefer folks migrate to alternative component implementations (which was unlocked by #213) like sparkles-component (largely a demo of the feature added in #213) or the future @glimmer/component interop.
Considering that we are actively pushing towards a "glimmer component" RFC (and already allow custom component managers and base classes via public APIs) making a change like this would likely introduce more churn for folks that ends up "feeling" like busy work when a better path would be to migrate towards one of the newer / simpler component types to begin with...
To append classes to a component's HTML, you can do a few things:
classNames: []
property to the JSclassNames = 'a b'
when invoking the componentclass = 'a b'
when invoking the componentConsidering that setting
class: []
in JS is not valid, I think 2 and 3 should be consolidated. My personal preference would be to deprecate/remove the third option.The text was updated successfully, but these errors were encountered: