Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of merged attributes for ...attributes #476

Closed
rwjblue opened this issue Apr 15, 2019 · 2 comments
Closed

Update list of merged attributes for ...attributes #476

rwjblue opened this issue Apr 15, 2019 · 2 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Apr 15, 2019

In emberjs/ember.js#17692 (comment) @MelSumner (correctly) called out that there are a number of important attributes other than class that should have the same sort of merging behaviors as class when using ...attributes.

for attributes coming from ARIA, there are five whose value is an ID reference list (meaning, they can have one or more values):

  • aria-controls - It seems like the order could possibly matter in some instances.
  • aria-describedby: order definitely matters
  • aria-flowto - the order could matter, depending on intent of content.
  • aria-labelledby - order definitely matters
  • aria-owns Order could matter, depending on design intent (if someone is using this, really we should make them stop and think twice tbh, it's smelly),

Rough TODO list:

  • Do some research to see if any additional attributes should have these behaviors. We can absolutely do more follow up RFCs so we don't have to be "perfect" here, but a quick review seems prudent.
  • We need to author an additional RFC to add these attributes to the list of "merged attributes" which modify the ...attributes behavior.
@rwjblue
Copy link
Member Author

rwjblue commented May 21, 2019

Some background context: emberjs/ember.js#13628

@MelSumner MelSumner removed the Octane label May 27, 2019
@wagenet
Copy link
Member

wagenet commented Jul 22, 2022

I'm closing this due to inactivity. This doesn't mean that the idea presented here is invalid, but that, unfortunately, nobody has taken the effort to spearhead it and bring it to completion. Please feel free to advocate for it if you believe that this is still worth pursuing. Thanks!

@wagenet wagenet closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants