Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember route variations (routable modals etc) #662

Closed
sandstrom opened this issue Sep 18, 2020 · 2 comments
Closed

Ember route variations (routable modals etc) #662

sandstrom opened this issue Sep 18, 2020 · 2 comments

Comments

@sandstrom
Copy link
Contributor

sandstrom commented Sep 18, 2020

What if the Ember Router introduced a new type of "sub-leaf" (could be called e.g. variation), that could be encoded as my/path#variation-{name} (for example)?

With routable variations we could, for example, show modals (i.e. routable modals) or toggle tabs on a page. Such route variations would share the modal hook etc (it would not re-run) and would be accessible from templates and controllers.

There is some precedent for this in the :target CSS selector, which can be used to show/hide various elements. For example, it's quite common to use that selector to toggle various tabs on a page.

https://css-tricks.com/on-target/

Admittedly there is some overlap with query-params here, don't know how to think about that.

Thoughts? Good, bad idea?

@wagenet
Copy link
Member

wagenet commented Jul 23, 2022

I'm closing this due to inactivity. This doesn't mean that the idea presented here is invalid, but that, unfortunately, nobody has taken the effort to spearhead it and bring it to completion. Please feel free to advocate for it if you believe that this is still worth pursuing. Thanks!

@wagenet wagenet closed this as completed Jul 23, 2022
@sandstrom
Copy link
Contributor Author

For reference, things along these lines are being discussed in #709.

I still think it would be a nice idea to explore, for example for modals. But I also agree that this needs to be spearheaded by someone, and right now that won't be me. So fine with closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants