Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Simplify adding new companies to the website #3215

Open
sivakumar-kailasam opened this issue Mar 7, 2018 · 9 comments
Open

Simplify adding new companies to the website #3215

sivakumar-kailasam opened this issue Mar 7, 2018 · 9 comments

Comments

@sivakumar-kailasam
Copy link
Member

For a new company to be added to https://emberjs.com/ember-users/ we require a PR. It might be easier if we could create an airtable form for these submissions & have an integration that'd automatically raise a PR to this repo.

@kennethlarsen
Copy link
Member

There are possible solutions which need to be discussed:

  1. Create an airtable form which triggers a bot to make a PR.
    This can definitely be done (however, a bit tricky since airtable still doesn't support notify new submissions via the API). But, we might end up with duplicated info that might desync.

  2. Create an airtable form and use the airtable API directly in the ember app.
    There are a few issues that need to be resolved here. First is validation on submitted images which is not possible on airtable (size and format). This would require some manual work and we would need to figure out how to tell the submitter to re-submit with a proper image.

  3. Create an airtable sheet and keep validation and form client side in the ember app.
    This way we use airtable as an API to submit and retrieve data but keep the form and validation in the app itself.

@sivakumar-kailasam
Copy link
Member Author

Another way to look at approach 1 is for us to run an app that can be run periodically that could look up the company's name from airtable on the yml file & then create the PR based on it.

@locks
Copy link
Contributor

locks commented Jan 16, 2019

@sivakumar-kailasam we have done work in this area, what's the current status?

@sivakumar-kailasam
Copy link
Member Author

I haven’t tried anything but I think @kennethlarsen did

@mansona
Copy link
Member

mansona commented Jan 16, 2019

There is a new system on the https://github.com/ember-learn/ember-website site that should significantly improve this situation. Each company has its own MD file (like most of our other data) and it currently works well with a generator approach

@kennethlarsen we should chat about this if you're still planning to look into it 👍

@kennethlarsen
Copy link
Member

@mansona I didn't get far with this because there didn't seem to be an agreement on the approach. The only thing there seemed to be a consensus about is that it would be neat with a form directly on the website to make it easier for everyone to add their company.

@mansona
Copy link
Member

mansona commented Jan 17, 2019

@kennethlarsen how about a form that created a PR? That seems like something within the realms of possibility with the new system 😂

@kennethlarsen
Copy link
Member

@mansona That sounds just like the kind of wizardry we need! 🧙

@mansona
Copy link
Member

mansona commented Jan 17, 2019

🎉 I'll add it to the list so 😂 Let me know if you would like to pair on a solution to this.

Also if you (or anyone) could give me an indication of the priority of this that would be great. Do we have a feel for how much of a problem it is for people? We seem to get a steady stream as is 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants