Projects on embroider don't see the "Non-colocated components" deprecation

[kategengler]

A project on latest ember-source (v5.10.2) with many non-colocated component templates wasn't seeing any deprecations for those templates. After investigating, I realized layoutFor (the method with the deprecation in ember-source) was never called: The project is using embroider -- embroider is resolving the component's templates at build time.

Embroider should add this deprecation.

Relevant RFC advancement PR emberjs/rfcs#1040

[mansona]

For stable embroider the relevant place is https://github.com/embroider-build/embroider/blob/stable/packages/core/src/module-resolver.ts#L482-L526

Essentially I think we would either need to check your ember-source version and throw the deprecation if your ember-version matches the deprecation, or we could just decide that when you're using embroider this is just deprecated anyway regardless of your ember-source version 🤔

I'm going to add this to the agenda for next week to discuss 👍

[ef4]

We discussed this at tooling team weekly meeting and the tentative plan is to emit a deprecation inside the virtual pair component at runtime (

embroider/packages/core/src/virtual-content.ts

Lines 67 to 77 in 8e5763c

	const pairedComponentShim = compile(`
	import { setComponentTemplate } from "@ember/component";
	import template from "{{{js-string-escape relativeHBSModule}}}";
	{{#if relativeJSModule}}
	import component from "{{{js-string-escape relativeJSModule}}}";
	export default setComponentTemplate(template, component);
	{{else}}
	import templateOnlyComponent from "@ember/component/template-only";
	export default setComponentTemplate(template, templateOnlyComponent(undefined, "{{{js-string-escape debugName}}}"));
	{{/if}}
	`) as (params: { relativeHBSModule: string; relativeJSModule: string | null; debugName: string }) => string;

) and also on Ember >= 6 do an actual build failure in the module-resolver where Chris linked above.

[kategengler]

Does this need to be backported? Users can easily upgrade ember-source without upgrading embroider.

[ef4]

Fixed in #2088.