Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres tables not cleaning #59

Open
brandon-leapyear opened this issue Feb 25, 2020 · 1 comment
Open

Postgres tables not cleaning #59

brandon-leapyear opened this issue Feb 25, 2020 · 1 comment

Comments

@brandon-leapyear
Copy link

A few problems came up for us:

  1. When database-cleaner lists out the tables to be deleted, the tables are not ordered by foreign key constraints. So we have child with a foreign key to parent, but DELETE FROM "parent" is attempted to be run before DELETE FROM "child", causing the table to not be deleted because there are still rows in child referencing parent

  2. When the above command didn't work, database-cleaner silently failed. I believe database-cleaner should check that the table was indeed cleared, and error otherwise.

Truncation seems to work for us. Is there a reason why truncation is not the default?

@emerleite
Copy link
Owner

@brandon-leapyear not exactly. Can you send a PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants