feat: Implement Close. #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Aug 22, 2022
session.go
Outdated
| @@ -210,8 +210,7 @@ func (m *milterSession) Process(msg *Message) (Response, error) { | |||
|
|
|||
| case CodeQuit: | |||
| // client requested session close | |||
| return nil, errCloseSession | |||
|
|
|||
| return m.backend.Close(newModifier(m)) | |||
There was a problem hiding this comment.
Before errCloseSession was returned, now it's never returned
There was a problem hiding this comment.
Sorry about this mistake.
Quote from sendmail milter doc: "Since the connection is already closing, the return value is currently ignored." So, How about not return any value in Close()?
Close(m *Modifier)
Then we can do this in Process():
case CodeQuit:
m.backend.Close(newModifier(m))
return nil, errCloseSession
There was a problem hiding this comment.
Updated PR. Please help review. @emersion
|
Dear @emersion, could you help review again? |
1 similar comment
|
Dear @emersion, could you help review again? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Close()method for theMilterinterface.fixes #20