Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu operation without a Queue #2084

Open
kvark opened this issue Sep 25, 2022 · 0 comments
Open

wgpu operation without a Queue #2084

kvark opened this issue Sep 25, 2022 · 0 comments
Labels
feature New feature or request rerun Desired for Rerun.io

Comments

@kvark
Copy link

kvark commented Sep 25, 2022

Is your feature request related to a problem? Please describe.
Functions from egui_wgpu_backend like update_buffers and add_textures require a wgpu::Queue argument. This is totally fine for many applications, and I assume it relies on queue.write_buffer and queue.write_texture internally, which are totally fine. However, in my case (and probably not just me), the drawing logic is encapsulated to produce command buffers, and it doesn't necessarily have access to a queue.

Describe the solution you'd like
Perhaps, a single call to update_resources that works with wgpu::CommandEncoder instead of wgpu::Queue. Internally, it would create a staging buffer with data, and/or re-use one from a pool.

Describe alternatives you've considered

Additional context
Downstream work is in kvark/vange-rs#214
Related to #2083 in a way that I'll likely to refactor egui logic out of the main render pass anyway, so this issue would not affect me as much as I thought. But once #2083 is addressed, it will be important for me again.
Also, thank you for the amazing library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request rerun Desired for Rerun.io
Projects
None yet
Development

No branches or pull requests

2 participants