Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 Removes query arguments from url #124

Closed
preliot opened this issue Nov 19, 2020 · 4 comments
Closed

1.3.0 Removes query arguments from url #124

preliot opened this issue Nov 19, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@preliot
Copy link

preliot commented Nov 19, 2020

Version 1.3.0 adds ?tab= to the url. The issue is it replaces any existing query string, which breaks any code that relies on that query string. Would be better if something like this is done:

  1. Retrieve query string, put in array
  2. Replace existing tab / add new tab=
  3. Implode array to url
@RVxLab
Copy link
Collaborator

RVxLab commented Nov 19, 2020

Crap, I didn't think of that when merging the PR for this. Thanks for your report, I'll take a look over the weekend.

@RVxLab RVxLab self-assigned this Nov 19, 2020
@RVxLab RVxLab added the bug Something isn't working label Nov 19, 2020
@preliot
Copy link
Author

preliot commented Nov 19, 2020

@RVxLab No worries! And thanks for taking some time for this in the weekend, i appreciate it!

@RVxLab RVxLab closed this as completed in 2379e33 Nov 22, 2020
@RVxLab
Copy link
Collaborator

RVxLab commented Nov 22, 2020

@preliot Your issue has been fixed, please update to 1.3.1.

@preliot
Copy link
Author

preliot commented Nov 23, 2020

Can confirm it's fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants