You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since your last updates, JSON Fields (for example https://github.com/armincms/json field, but probably similar as well) are broken. I am getting Undefined property: Armincms\Json\Json::$panel in vendor/eminiarts/nova-tabs/src/Tabs.php:50:
if ($field instanceof MergeValue) {
if (null === $field->panel) {
$field->panel = $this->name;
}
$this->addFields(
newTab($tab->getTitle(), $field->data)
);
continue;
}
MergeValues doesn't have to have defined panel's, right?
The text was updated successfully, but these errors were encountered:
Correct. I have fixed it with if ($field instanceof MergeValue && isset($field->panel)) {. Should I do a PR for it or is it easier if you fix it yourself?
Since your last updates, JSON Fields (for example https://github.com/armincms/json field, but probably similar as well) are broken. I am getting
Undefined property: Armincms\Json\Json::$panel
invendor/eminiarts/nova-tabs/src/Tabs.php:50
:MergeValues doesn't have to have defined
panel
's, right?The text was updated successfully, but these errors were encountered: