Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete files from file fields #158

Closed
PCodrin opened this issue Jul 13, 2021 · 7 comments
Closed

Cannot delete files from file fields #158

PCodrin opened this issue Jul 13, 2021 · 7 comments

Comments

@PCodrin
Copy link

PCodrin commented Jul 13, 2021

image

@RVxLab
Copy link
Collaborator

RVxLab commented Jul 22, 2021

I fail to see how this is caused by nova-tabs. You have a 404, sounds like a problem within your resource.

@PCodrin
Copy link
Author

PCodrin commented Jul 22, 2021

That occurs when you add a File field in a tab just try to see if it works. Thanks!

@arlon23
Copy link
Contributor

arlon23 commented Oct 22, 2021

@RVxLab I don't know if it could help, but I was looking into this problem, and i see the problem may be the findFieldByAttribute() method in FieldCollection, i guess it not using the method created in this package, it is using from laravel.

@Kenny201
Copy link

Got the same problem. Does anybody know how to fix it?

@arlon23
Copy link
Contributor

arlon23 commented Dec 20, 2021

@Kenny201 @PCodrin I did this change on updateFields and it seems to fix the problems, I didin't make all the tests on my project, but if you want to try and test on your projects, after I finish with my test I will make a PR.

This TabFieldCollection is the FieldCollection file found in this package

image

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 9, 2022

This should be fixed with #169. I’ll make a release towards the weekend.

@RVxLab RVxLab closed this as completed Feb 9, 2022
@RVxLab
Copy link
Collaborator

RVxLab commented Feb 13, 2022

Version 1.5.0 has been released which should address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants