Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart should support namespace, ambassador_id, and SINGLE_NAMESPACE #588

Closed
kflynn opened this issue Jul 3, 2018 · 4 comments
Closed

Comments

@kflynn
Copy link
Member

kflynn commented Jul 3, 2018

Right now, the Helm chart totally ignores namespace. That's obviously a problem.

Realistically, the chart needs to also support ambassador_id and AMBASSADOR_SINGLE_NAMESPACE.

@endrec
Copy link
Contributor

endrec commented Jul 17, 2018

the Helm chart totally ignores namespace
As far as I know (though I'm just started with Helm charts), if the templates do not set the namespace, everything will be rendered in .Release.Namespace. This is the case with the ambassador chart.

Supporting ambassador_id and AMBASSADOR_SINGLE_NAMESPACE raises some questions:

  • does ambassador_id makes sense when AMBASSADOR_SINGLE_NAMESPACE is set?
  • what value does AMBASSADOR_SINGLE_NAMESPACE expect?

@MichielDeMey
Copy link
Contributor

  1. It doesn't, they are mutually exclusive. When only 1 namespace is required, there is no need to set an identifier. (See https://www.getambassador.io/reference/running#multiple-ambassadors-in-one-cluster)
  2. The value does not matter, the code only checks the existence of the environment variable.
    The example simply sets it to "YES", cfr. https://github.com/datawire/ambassador/blob/69f224a7988b89becb13ecbc31fdf41af438a3e9/end-to-end/fixes/single-namespace.yfix#L4-L5

@MichielDeMey
Copy link
Contributor

@kflynn I took a stab at it in #657

@kflynn
Copy link
Member Author

kflynn commented Mar 19, 2019

I believe that this is definitely handled by the chart in helm/stable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants