Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matching criteria to kat tests #814

Closed
kflynn opened this issue Sep 17, 2018 · 3 comments
Closed

Add matching criteria to kat tests #814

kflynn opened this issue Sep 17, 2018 · 3 comments
Assignees

Comments

@kflynn
Copy link
Member

kflynn commented Sep 17, 2018

Kat doesn't currently test regex matches or header matches. We need to add this.

This might be best done as a MatchTest which extends MappingTest.

@kflynn kflynn changed the title Add regex matching to kat tests Add matching criteria to kat tests Sep 17, 2018
@kflynn
Copy link
Member Author

kflynn commented Nov 6, 2018

This is opening a larger can of worms than we expected, but it still has to get done.

Current thought is to have MatchTest in parallel to OptionTest. A MatchTest defines how we'll match requests to Mappings, where an OptionTest defines other behavior once a match occurs.

@kflynn
Copy link
Member Author

kflynn commented Nov 7, 2018

Some specific things that need more coverage:

  • SNI
  • header matching

@kflynn
Copy link
Member Author

kflynn commented Apr 25, 2019

We've managed to cover SNI and header matching, though not as gracefully as I'd've liked in some cases. Closing this one; we can open other issues as needed.

@kflynn kflynn closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant