Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX & VS Code plugin: "wrap with abbreviation" fails with a quote #734

Open
noahlt opened this issue Nov 8, 2024 · 0 comments
Open

JSX & VS Code plugin: "wrap with abbreviation" fails with a quote #734

noahlt opened this issue Nov 8, 2024 · 0 comments

Comments

@noahlt
Copy link

noahlt commented Nov 8, 2024

VSCode Emmet plugin fails to run Wrap with abbreviation in this case, maybe because it thinks that you’re trying to wrap attribute and quote makes this attribute invalid:

export default function Test() {
  return (
    <AbstractComponent
      render={() => {
        return (
          <p>example's</p>
        );
      }}
    />
  );
}

If you select the

element and try to run "wrap with abbreviation" inside VS code, it fails — doesn't even pop the "enter abbreviation" prompt. This seems to be due to the single quote, probably breaking Emmet's parser.

Note that this seems to interact with #733 somehow, because the following example has no problem:

function Foo() {
	return (
		<div>example's</div>
	)
}

Thanks for all your wonderful work on Emmet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant