Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize get_descendants and get_ancestors #406

Closed
francescalb opened this issue Apr 28, 2022 · 0 comments · Fixed by #572
Closed

Harmonize get_descendants and get_ancestors #406

francescalb opened this issue Apr 28, 2022 · 0 comments · Fixed by #572
Assignees
@francescalb

Comments

@francescalb
Copy link
Collaborator

get_descendants uses 'generations' as argument. I suggest using the same, and that the same names are used for the arguments in both functions.

Also add a test for get_ancestors.
@francescalb francescalb self-assigned this Mar 13, 2023
@francescalb francescalb linked a pull request Mar 16, 2023 that will close this issue
get_ancestors and get_descendants have the same arguments. #572
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francescalb francescalb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

get_ancestors and get_descendants have the same arguments. emmo-repo/EMMOntoPy
1 participant
@francescalb