Glamorous -> Emotion -- Prop filtering?

[brentertz]

Greetings! Recent conversations about the potential deprecation of Glamorous led me to consider a migration to Emotion. paypal/glamorous#419

While the API's are similar, they are not quite identical. One feature that my project relies on heavily in Glamorous is prop filtering, as described by the rootEl, forwardProps, and filterProps sections at https://glamorous.rocks/api

Would this be something that you might consider including in Emotion?

Thanks!

[Andarist]

There is shouldForwardProp feature option and you can use it like this:

import isPropValid from '@emotion/is-prop-valid'

const StyledTextarea = styled(TextareaAutosize, { shouldForwardProp: isPropValid })({
  fontSize: '16px',
})

You can also look at this test case to see how it can be used.

[brentertz]

@Andarist Thanks for pointing out shouldForwardProps option.

Are those options part of the public API? I could find no references to them in the documentation, only in the source here and here.

Oooh, just noticed the is-prop-valid comment above... investigating more...

[Andarist]

Yeah, they are part of the public API. They might have not been documented though - this is quite a new option, implemented not that long time ago. Would be good to have a docs for it, I've created an issue about it here. We'd love some help with that 😉

[brentertz]

Thank you. It appears as though the shouldForwardProp option will work fine for my use case with the forthcoming addition of #670