Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0008-community-plugins.md needs discuss #23

Open
wivwiv opened this issue Mar 10, 2021 · 1 comment
Open

0008-community-plugins.md needs discuss #23

wivwiv opened this issue Mar 10, 2021 · 1 comment
Assignees

Comments

@wivwiv
Copy link
Member

wivwiv commented Mar 10, 2021

@z8674558

Yes, I think it's important to support and promote community plug-ins.

EMQ encourages the community to contribute useful plug-ins. If we do it well enough, we can help the author promote it.

0008 is a little simple and inflexible

  1. How to approve new plug-ins for the released EMQ X version
  2. The security of the plug-in, whether the plug-in is officially recommended by EMQ, and whether it infringes the copyright or interests of some people
  3. The version compatibility of the plug-in, users may ask: this plug-in is cool, but can I use it in my EMQ X?

Grafana sign-a-plugin
Grafama plugins

We can build an online plug-in market, which has been discussed before, but we have encountered some technical problems.

If we can solve the problem now, the plug-in market looks very cool

  1. Can we provide a *.zip file (plugin installation package, like emqx_auth_sqlite_plugins.zip), which contains the main *.beam file. The user can set it to the lib/ directory, unzip it, and reload it?

Usage

wget https://market.emqx.io/plugins/emqx/emqx_auth_sqlite.zip?version=1.3.1
unzip emqx_auth_sqlite.zip
mv emqx_auth_sqlite/ /opt/emqx/lib/

emqx_ctl plugins load  emqx_auth_sqlite
@6293
Copy link
Contributor

6293 commented Mar 11, 2021

@wivwiv

How to approve new plug-ins for the released EMQ X version

If a plugin is approved after the release of v4.3.1, for example, the plugin is listed as approved from v4.3.2.

The security of the plug-in, whether the plug-in is officially recommended by EMQ,

We can provide approved badge that can be included in README in a plugin's github repository.

and whether it infringes the copyright or interests of some people

We need to check if plug-in's dependencies have OSS licenses that allow us to use the software.

The version compatibility of the plug-in, users may ask: this plug-in is cool, but can I use it in my EMQ X?

Using CI, we ensure that approved plugins pass common tests with emqx loaded. Once passed, we can add the version information to the above-mentioned badge. We may obligate some test coverage before we approve a plugin.

We can build an online plug-in market, which has been discussed before, but we have encountered some technical problems.

Sounds nice. I am not sure if we can do it now though. Further investigation needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants