Skip to content

Commit 160bf62

Browse files
committed
Delete invalid test
Test expectations were incorrect: it mixed up int64/uint64 and was returning negative number in uint64 function and expecting the negative sign to be preserved. Now that behaviour of uint64 is fixed, this expectation doesn't hold. Additionally, it was relying on the `n` suffix being printed by `console.log`, which is not portable and is not printed in e.g. latest Node.js. The correct test is now better served by test_i64_binding which correctly checks the type limits, signs, and will also run across more engines.
1 parent ac8a2d1 commit 160bf62

File tree

2 files changed

+0
-31
lines changed

2 files changed

+0
-31
lines changed

test/embind/test_embind_long_long.cpp

Lines changed: 0 additions & 23 deletions
This file was deleted.

test/test_other.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3396,14 +3396,6 @@ def test_embind_return_value_policy(self):
33963396

33973397
self.do_runf('embind/test_return_value_policy.cpp')
33983398

3399-
@parameterized({
3400-
'': [[]],
3401-
'asyncify': [['-sASYNCIFY=1']],
3402-
})
3403-
def test_embind_long_long(self, args):
3404-
self.do_runf('embind/test_embind_long_long.cpp', '1000000000000n\n-1000000000000n',
3405-
emcc_args=['-lembind', '-sWASM_BIGINT'] + args)
3406-
34073399
@requires_node_canary
34083400
def test_embind_resource_management(self):
34093401
self.node_args.append('--js-explicit-resource-management')

0 commit comments

Comments
 (0)