Add assertion checking if too many args are passed into exports. (#21349)

* Add assertion checking if too many args are passed into exports.

Fixes #21348

* Fix webidl constructor number of arguments.

Author: brendandahl

src/preamble.js

@@ -495,14 +495,16 @@ Module['FS_createPreloadedFile'] = FS.createPreloadedFile;
 #include "URIUtils.js"
 
 #if ASSERTIONS
-function createExportWrapper(name) {
+function createExportWrapper(name, nargs) {
   return (...args) => {
     assert(runtimeInitialized, `native function \`${name}\` called before runtime initialization`);
 #if EXIT_RUNTIME
     assert(!runtimeExited, `native function \`${name}\` called after runtime exit (use NO_EXIT_RUNTIME to keep it alive after main() exits)`);
 #endif
     var f = wasmExports[name];
     assert(f, `exported native function \`${name}\` not found`);
+    // Only assert for too many arguments. Too few can be valid since the missing arguments will be zero filled.
+    assert(args.length <= nargs, `native function \`${name}\` called with ${args.length} args but expects ${nargs}`);
     return f(...args);
   };
 }

test/test_other.py

@@ -12035,6 +12035,20 @@ def test_native_call_after_exit(self):
     out = self.run_js('foo.js', assert_returncode=NON_ZERO)
     self.assertContained('native function `main` called after runtime exit', out)
 
+  def test_native_call_nargs(self):
+    self.set_setting('ASSERTIONS')
+    self.set_setting('EXPORTED_FUNCTIONS', ['_main', '_foo'])
+    create_file('foo.c', r'''
+      #include <emscripten.h>
+      void foo(int arg) {}
+      int main() {
+        EM_ASM(_foo(99, 100));
+      }
+    ''')
+    self.build('foo.c')
+    out = self.run_js('foo.js', assert_returncode=NON_ZERO)
+    self.assertContained('native function `foo` called with 2 args but expects 1', out)
+
   def test_metadce_wasm2js_i64(self):
     # handling i64 unsigned remainder brings in some i64 support code. metadce
     # must not remove it.

tools/emscripten.py

@@ -885,7 +885,7 @@ def install_wrapper(sym):
     if settings.ASSERTIONS and install_wrapper(name):
       # With assertions enabled we create a wrapper that are calls get routed through, for
       # the lifetime of the program.
-      wrapper += "createExportWrapper('%s');" % name
+      wrapper += f"createExportWrapper('{name}', {nargs});"
     elif settings.WASM_ASYNC_COMPILATION:
       # With WASM_ASYNC_COMPILATION wrapper will replace the global var and Module var on
       # first use.

tools/webidl_binder.py

@@ -536,7 +536,7 @@ def is_ptr_arg(i):
         elif arg_type == 'Double':
           body += "  if (typeof {0} == 'object') {{ {0} = ensureFloat64({0}); }}\n".format(js_arg)
 
-  call_args = pre_arg
+  call_args = pre_arg.copy()
 
   for i, arg in enumerate(args):
     if options.wasm64 and is_ptr_arg(i):