Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idbfs backend: If reconcile() triggers QuotaExceededError, callback is never called #21325

Closed
past-due opened this issue Feb 13, 2024 · 0 comments · Fixed by #21326
Closed

idbfs backend: If reconcile() triggers QuotaExceededError, callback is never called #21325

past-due opened this issue Feb 13, 2024 · 0 comments · Fixed by #21326

Comments

@past-due
Copy link
Contributor

In library_idbfs.js's reconcile() function, the transaction may abort if (for example) a QuotaExceededError occurs.

However, since no abort/onabort handler is currently added, the callback will never be called in this case.

Expected behavior:

The callback passed-in to reconcile() is called with the error, even if the transaction aborts.

Version of emscripten/emsdk:
3.1.53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

library_idbfs.js: Handle transaction.onabort in reconcile() past-due/emscripten
1 participant
@past-due