Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor more recent node version? #1064

Open
hoodmane opened this issue Jun 25, 2022 · 4 comments
Open

Vendor more recent node version? #1064

hoodmane opened this issue Jun 25, 2022 · 4 comments

Comments

@hoodmane
Copy link

Emsdk includes node v14.18 which is quite old. In particular, one annoying thing about it is that it requires the --experimental-wasm-bigint flag which is poorly documented (it doesn't appear in node --help) and future versions of node error out if passed --experimental-wasm-bigint so it's pretty hard to handle new and old nodes. Also, the error message wasm function signature contains illegal type has nothing that suggests it has anything to do with -sWASM_BIGINT or with --experimental-wasm-bigint or anything. This is wasting a fair amount of time for various people who are seeing this bug and having to investigate. I think it would help a lot to vendor a newer version, say v16.15 LTS.

@hoodmane
Copy link
Author

This is a new problem that we have since we started passing -sWASM_BIGINT.

@sbc100
Copy link
Collaborator

sbc100 commented Jun 27, 2022

We have previously tried and failed to update the version of node that we ship. See #877 and #947 for more context.

It might be possible, but its not trivial.

@hoodmane
Copy link
Author

hoodmane commented Jun 27, 2022

Perhaps we could try to fix node? In node 14:

  1. Add --experimental-wasm-bigint to the help text
  2. Fix the wasm function signature contains illegal type error message to mention the --experimental-wasm-bigint

In node > 14:

  1. accept and ignore the --experimental-wasm-bigint flag

@Jimimaku
Copy link

Jimimaku commented Nov 27, 2022

Emsdk enthält Knoten v14.18, der ziemlich alt ist. Insbesondere ist eine ärgerliche Sache, dass es das Flag erfordert, das schlecht dokumentiert ist (es erscheint nicht in) und zukünftige Versionen des Knotenfehlers, wenn es übergeben wird, so dass es ziemlich schwierig ist, neue und alte Knoten zu behandeln. Außerdem hat die Fehlermeldung nichts, was darauf hindeutet, dass sie etwas mitoder mit irgendetwas zu tun hat. Dies verschwendet eine Menge Zeit für verschiedene Leute, die diesen Fehler sehen und untersuchen müssen. Ich denke, es würde sehr helfen, eine neuere Version zu verkaufen, sagen wir v16.15 LTS.--experimental-wasm-bigint``node --help``--experimental-wasm-bigint``wasm function signature contains illegal type``-sWASM_BIGINT``--experimental-wasm-bigint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants