Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jvec/jtvec #255

Open
8 of 14 tasks
prisae opened this issue Sep 5, 2021 · 0 comments
Open
8 of 14 tasks

Improve jvec/jtvec #255

prisae opened this issue Sep 5, 2021 · 0 comments
Labels
docs Stuff related to the documentation enhancement New feature or request examples Add to or improve the gallery
Milestone

Comments

@prisae
Copy link
Member

prisae commented Sep 5, 2021

e4d6ac8 introduced jvec and jtvec. There are a couple of things that need improvements down the road. An issue to keep track of it:

  • Restructure the internal layout of gradient/_bcompute/_get_rfield/_jvec/_jtvec
  • Expand documentation, adding the derivation for jvec and jtvec in more detail
  • Optimize the entire gradient-chain for speed
  • Add an example to the gallery using SimPEG(emg3d)

Also, testing should be improved:

  • Add adjoint tests and derivative tests using discretize
    • src-rec
    • mapping
    • interpolation
    • jvec/jtvec (overall)

More work is required to make it possible to have automatic gridding ('gridding' != 'same').

  • SimPEG@emg3d-solver needs adjustments to work with different inversion and computational grids
  • jvec: vector should probably be a Model (needs adjustments in SimPEG@emg3d-solver)
  • jtvec: vector should probably be a DataArray (needs adjustments in SimPEG@emg3d-solver) (both is already possible, ndarray or DataArray)
  • Check interpolations; maps.interp_edges_to_vol_averages; grid.get_edge_inner_product_deriv
  • Automatic gridding SimPEG@emg3d-solver: Which model is used when to create grids? Needs work

Current relevant branches:

@prisae prisae added enhancement New feature or request docs Stuff related to the documentation examples Add to or improve the gallery labels Sep 5, 2021
@prisae prisae pinned this issue Sep 5, 2021
@prisae prisae unpinned this issue Mar 3, 2024
@prisae prisae added this to the Inversion milestone Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Stuff related to the documentation enhancement New feature or request examples Add to or improve the gallery
Projects
None yet
Development

No branches or pull requests

1 participant