Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get enb-magic-factory within platform #49

Open
tadatuta opened this issue May 27, 2015 · 2 comments
Open

Can't get enb-magic-factory within platform #49

tadatuta opened this issue May 27, 2015 · 2 comments

Comments

@tadatuta
Copy link
Member

Project to reproduce: https://github.com/theprotein/svg-example

Error text:

TypeError: Cannot read property 'getMetaTaskName' of undefined
    at module.exports (/Users/tadatuta/Sites/svg-example/node_modules/enb-magic-platform/lib/run-tasks.js:14:27)

In run-tasks.js:

module.exports = function (tasks, makePlatform, opts) {
    var factory = makePlatform._projectConfig._modules['enb-magic-factory'],

in runtime makePlatform._projectConfig._modules is just an empty object.

enb-magic-factory is installed:

ls node_modules/ | grep magic
enb-magic-factory
enb-magic-platform

This check https://github.com/enb-bem/enb-magic-platform/blob/7891309dda2fe1a4ed297f3310964c28a2d6d13b/lib/run-tasks.js#L21 was never reached.

I tryed to update npm deps:

diff --git a/package.json b/package.json
index 0359106..8c97639 100644
--- a/package.json
+++ b/package.json
@@ -12,12 +12,12 @@
     "bower-npm-install": "~0.5.4",
     "csscomb": "~3.0.3",
     "cssparser": "^0.2.2",
-    "enb": "0.13.11",
-    "enb-autoprefixer": "0.2.0",
-    "enb-bem-techs": "1.0.0",
+    "enb": "~0.15.0",
+    "enb-autoprefixer": "0.3.0",
+    "enb-bem-techs": "1.0.4",
     "enb-bemxjst": "1.3.3",
-    "enb-borschik": "1.4.0",
-    "enb-magic-platform": "0.4.1",
+    "enb-borschik": "1.5.0",
+    "enb-magic-platform": "0.5.0",
     "enb-modules": "0.2.0",
     "enb-stylus": "^1.2.3",
     "fs-extra": "^0.18.3",
@@ -26,6 +26,7 @@
     "jshint": "2.5.11",
     "jshint-groups": "0.6.2",
     "lodash": "^3.8.0",
+    "nodemon": "^1.3.7",
     "stylus": "0.49.3",
     "svgo": "0.5.0"
   },

but with no luck.

// cc @verybigman

@tadatuta tadatuta added the bug label May 27, 2015
@awinogradov
Copy link

hmm... work fine for me. Use enb make instead magic make

@tadatuta
Copy link
Member Author

@verybigman yup, looks like it really works with enb make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants