Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValueError: list.remove(x): x not in list (#670) #680

Merged
merged 5 commits into from
May 17, 2023
Merged

Fix ValueError: list.remove(x): x not in list (#670) #680

merged 5 commits into from
May 17, 2023

Conversation

Tunglies
Copy link
Contributor

@Tunglies Tunglies commented May 8, 2023 •
edited
Loading

Fixs ValueError: list.remove(x): x not in list (#670)

It seemed delete item from self._requests but item not exists.

Tunglies

This comment was marked as abuse.

Sign in to view

tomchristie
tomchristie requested changes May 10, 2023
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd need this change in both the _sync and _async cases.

(Our development workflow is to make the changes in the _async case and then run ./scripts/unasync, to ensure the two cases match)

@Tunglies
Copy link
Contributor Author

Tunglies commented May 10, 2023 •
edited
Loading

We'd need this change in both the _sync and _async cases.

(Our development workflow is to make the changes in the _async case and then run ./scripts/unasync, to ensure the two cases match)

Thanks.

@Tunglies Tunglies requested a review from tomchristie May 10, 2023 12:48
@tomchristie tomchristie mentioned this pull request May 17, 2023
Merged
@tomchristie tomchristie merged commit 31b8f52 into encode:master May 17, 2023
@tomchristie tomchristie mentioned this pull request May 17, 2023
Closed
@dimaqq
Copy link

dimaqq commented May 17, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tunglies @dimaqq @tomchristie